Repository navigation
CI only: Windows deadline test waits for readiness - #17
Merged
Merged
Conversation
Author
|
Closing: CI-only branch; its change reaches main through the gated push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-only draft for a worker's Windows proof. Not for merging; the change reaches main through the gated push.
Summary by cubic
Makes the Windows subprocess deadline tests reliable by starting the output deadline only after confirming the descendant process is actually running.
output_until_ready, which polls a readiness predicate on Windows before starting the output deadline timer.Written for commit 33478e8. Summary will update on new commits.