Repository navigation
CI only: external audit cleanup (cross-crate) - #16
Closed
basal-alfonso[bot] wants to merge 2 commits into
Closed
basal-alfonso[bot] wants to merge 2 commits into
basal-alfonso[bot] wants to merge 2 commits into
Conversation
Share hex, poison-tolerant locking, position conversion, refusal encoding, settlement and clock helpers without changing their contracts. Narrow internal APIs and remove unused mock controls. Test-only hosts, catalogs, selectors, resolvers, polling helpers and harnesses require explicit test support; aliased development dependencies preserve package-qualified feature flags. Drop the ownership boolean ignored by every production configure_flow endpoint. Test recordings retain scope and lifecycle assertions but no longer assert the vacuous forwarded flag. Batch health token windows in one statement, prove unauthorized fetches do not resolve, and distinguish listener retry errors from fatal errors. Reduce the identified oversized functions while keeping commit and hook ordering, and retain an independent literal oracle when sharing schedule ID formatting. Production staging rejects retained test-support markers, with release-byte positive and negative controls and an offline script test. Re-anchor extracted guards and prove 18 controls on their declared hosts. Workspace tests and both warning-denying clippy configurations passed on Linux and macOS; final helper edits have package-scoped follow-up coverage. Windows verification is requested separately.
Reuse ck-basal's checked strings table instead of reading it again for the test-support marker. Isolate strings and nm failures per executable, including partial stdout, so a later failing read cannot hide an earlier fail-open inspection. Preserve the existing strings and symbol mutation anchors unchanged. Use python3 in the new command control, matching the CI runner's available interpreter. The support-marker, strings-failure and symbol-failure controls are caught on Linux, with exact named failures and indexed applied/restored diffs; all 84 script tests and repository script fences pass.
Author
|
Closing: CI-only branch; its change reaches main through the gated push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-only draft for a worker's Windows proof. Not for merging; the change reaches main through the gated push.
Summary by cubic
CI-only cleanup that consolidates duplicated helpers and fences test-only code behind a new
test-supportfeature. No production behavior changes; the change reaches main through the gated push. Also fixes an oversight so staging inspections stay fail-closed: the test-support marker is read from ck-basal's checked strings table instead of a second read, and strings/nm failures are isolated per binary, so a later failed read cannot mask an earlier fail-open check.Refactors
basal_proto::util.agent_ownedargument fromconfigure_flowacross all call sites.driver.rs,manifest.rs, andops.rswithout changing behavior.Migration
StaticResolver,ManualClock,FakeSelector, and the module harness now requirecfg(test)or the owning crate'stest-supportfeature.cargo test.BASAL_TEST_SUPPORT_ENABLEDmarker.Written for commit 5b41c51. Summary will update on new commits.