Skip to content

test: a missed held-sync arrival fails its own test instead of hanging cleanup #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ualtinok merged 1 commit into from
Oct 21, 2026
+8 −3
Merged

test: a missed held-sync arrival fails its own test instead of hanging cleanup #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/opencode/src/tests/quota-sweep.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,9 @@ test('quota poll serves its reading while runtime sync is held and dispose drain
const f = await startBody({ quotaEnabled: false, fallbackUsed: 20 })
await f.startupSweep
const held = lifetimes.gate()
const arrived = signal()
// A publication may never reach the spy. Release its arrival wait on teardown
// so a timed-out body can settle before the lifetime restores fetch and files.
const arrived = lifetimes.gate()
const stallDeadline = () =>
new Promise<string>((resolve) =>
setTimeout(() => resolve('blocked on sync'), 250),
Expand All @@ -900,7 +902,7 @@ test('quota poll serves its reading while runtime sync is held and dispose drain
staged.accounts[FALLBACK_ID]?.quotaErrorClearedAt
) {
intercepted = true
arrived.resolve()
arrived.open()
await held.wait
}
return sync()
Expand All @@ -911,7 +913,10 @@ test('quota poll serves its reading while runtime sync is held and dispose drain
)
lifetimes.deferCleanup(() => openSpy.mockRestore())
const request = f.request()
await arrived.promise
await arrived.wait
// Teardown also opens this gate after a timeout and stops the plugin.
// Do not continue into its account reads or requests without an interception.
if (!intercepted) return
const result = await Promise.race([
request.then(() => 'served'),
stallDeadline(),
Expand Down
Loading