Repository navigation
deps: @types/bun 1.4.3 - #386
Merged
Merged
Conversation
Bun.Subprocess signalCode is now number | Signals | null; the test result type follows it.
…@types/bun 1.4.3 @types/bun 1.4.3 declares Subprocess.signalCode as NodeJS.Signals | number | null (a number for signals with no name). The mutation wrapper's Transcript.signal and OwnedChild.signalCode, and the Pi host check's ChildOutcome.signal, now use Bun's own type. Types only: runtime values, the `signal ||` death check, and every recorded JSON (invocation.json, status.json, the Pi failure dump) are unchanged. Bun 1.3.14 already returns a number at runtime for an unnamed signal (probe: kill -35 -> 35), so the recorded format was already string-or-number.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
@types/bunfrom 1.4.2 to 1.4.3 and supersedes the Dependabot PR, which failed the typecheck. In 1.4.3,Bun.Subprocess["signalCode"]isNodeJS.Signals | number | null(a number for a signal with no name). Our scripts and one test declared it asstring | null; they now use Bun's own type. Types only: Bun 1.3.14 already returns a number at runtime for an unnamed signal, so recorded JSON (the mutation auditinvocation.json, CI status files, the Pi failure dump) is unchanged.Summary by cubic
Updates
@types/bunfrom 1.4.2 to 1.4.3 and adapts signal type declarations to Bun's own types, superseding a Dependabot PR that failed the typecheck.Bun.Subprocess["signalCode"]isNodeJS.Signals | number | null, where a number is reported for signals with no name.signalCodeasstring | null; they now useBun.Subprocess['signalCode'].Written for commit 34c8539. Summary will update on new commits.