Repository navigation
land: path-status-batch - #569
Merged
Merged
Conversation
Use one IMMEDIATE transaction for each pending set in configure, view assembly, and refresh retry fanout. Share the existing age-preserving upsert and leave synchronous FULL unchanged. A single transaction gives all-or-nothing cancellation/crash recovery rather than a partially applied prefix. Add mixed-state equivalence, SQL failure/cancel rollback, abrupt process exit, and SQLite statement transaction-count tests. The real refresh caller's 5000-row test fails at 5000 commits before the fix and when that caller is mutated back to its per-row loop; the other 12 targeted tests remain green. Linux fresh owner-identical worker measurement: annotation writes 32,355,708 -> 2,284,692 bytes; sync calls 5,327 -> 13. View integration (15), caller unit gates (708), strict Windows cross-check and cargo fmt pass. Investigation/evidence retained uncommitted under .cortexkit/internal-docs/investigations/path-status-batch.md. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Batches pending path-status annotations in configure, view assembly, and refresh retry fanout so each set commits in one IMMEDIATE transaction instead of one sync per path.
synchronous=FULLdurability unchanged.Written for commit f4677ec. Summary will update on new commits.


Confidence Score: 5/5
This PR appears safe to merge; no actionable issues were found.Summary
This PR saves pending path statuses in batches instead of committing each path separately.
No actionable issues were found. Tests were inspected but not run.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Configuration] --> D[mark_pending_many] B[View assembly] --> D C[Refresh retry] --> D D --> E{Any paths?} E -- No --> F[Return without a transaction] E -- Yes --> G[Begin immediate transaction] G --> H[Write each pending status] H --> I[Commit once] H -- Error or unwind --> J[Roll back]Reviews (1) · Last reviewed commit: "release notes and search-quality descrip..." · Reviewed by Greptile