Repository navigation
land: deferred-bash-idle-timer-test - #553
Merged
github-merge-queue[bot] merged 2 commits intoOct 18, 2026
Merged
Conversation
The helper capped every wait:true call at 200 ms, including its primary-session completion case. A timer turn could correctly hand back running before the shell exit was observed, despite the five-second outer guard. Give terminal cases a cap beyond that guard while preserving the 200 ms promotion and worker-cap cases, first-reply status assertions, and zero producer-wake generation. Linux baseline passed 50/50; injecting 400 ms command-exit latency reproduced running versus completed before the change and passed 50/50 after it. Reversing the cap with that same latency failed only the completion case; the other four idle-timer cases passed. Final gates: 86 subc tests, 25 bash orchestration tests, Windows warnings-as-errors cross-check, and local rustfmt. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
…mer-test Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Fixes the bash idle-timer test helper so
wait: trueterminal cases no longer compete with a 200 ms worker cap before the shell exit is observed.running; completed cases use a 30 s cap beyond the outer timeout.Written for commit b4dc71f. Summary will update on new commits.
This PR appears safe to merge.Summary
This PR removes a competing 200 ms deadline from terminal-state bash tests.
Reviews (1) · Last reviewed commit: "release notes and search-quality descrip..." · Reviewed by Greptile