Repository navigation
land: pr-diff-read - #535
Merged
Merged
Conversation
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
A PR whose changes were all reverted makes the paginated jq projection print nothing. That is an empty file list, not an invalid line. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 18, 2026
The routing test fed the files listing as one JSON array, the shape of the old slurped request. Real gh applies the jq filter to each page and prints one value per line, and refuses --slurp together with --jq. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Fixes reading pull request diffs so
pr://N/diffandpr://N/diff/<path>work again; they previously failed with aghflag error, and a PR whose changes were all reverted now returns an empty diff instead of failing.ghrejects combining--slurpwith--jq, so the changed-path listing now parses newline-delimited JSON objects instead of a slurped array.ghdouble to answer per-page jq output like the real CLI.Written for commit 1b04c58. Summary will update on new commits.
The PR appears safe to merge; no blocking issue remains.Summary
Fixes pull request diff reads by removing incompatible
ghflags and reading changed paths as newline-separated JSON.Reviews (3) · Last reviewed commit: "Make the recorded gh double answer per-p..." · Reviewed by Greptile