Repository navigation
land: windows-configure-checkpoint-tests - #505
Merged
github-merge-queue[bot] merged 2 commits intoOct 18, 2026
Merged
Conversation
…checkpoint dir rollback) configure_cancellation_stops_the_git_probe_retry_ladder failed on Windows CI with "stubbed git probe did not start": the test gave configure a 2 s wall-clock budget to reach the stubbed git probe, and everything configure does first (real git spawns, storage setup) can exceed that on a loaded runner. The stub now holds its first attempt in flight until the test releases it, and the test waits for the probe to start or for configure to finish without reaching it (120 s hang guard only). Because the cancel now lands while attempt 1 is known to be held, the cancellation assertion is tightened from "at most one more attempt" to "no further attempt". checkpoint_restore_failure_removes_created_parent_dirs failed on Windows CI inside its fixture: tempfile::NamedTempFile::new() in the runner's shared TEMP returned "Access is denied" (os error 5) before any checkpoint code ran. The checkpoint_file helper now builds the entry in memory. Reading the test also showed it never reached the rollback: its blocking path was a pre-existing directory, which the pre-restore snapshot refuses before anything is written, so a no-op rollback_created_dirs left it green. The failing second path is now the directory the first restore creates, so the write really happens and really fails, and the rollback must remove the created parents. The old "pre-existing blocking directory remains" check is replaced by asserting the pre-existing parent directory remains, since there is no pre-existing blocking directory any more. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
…ckpoint-tests Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Fixes two Windows-flaky tests in
crates/aftand adds a benchmark slice descriptor for this branch; no production behavior changes.Written for commit 9d68b18. Summary will update on new commits.
This PR appears safe to merge; no actionable issues were found.Summary
This PR makes Windows-sensitive tests less dependent on temporary files and machine speed.
No actionable issues were found. Tests were not run.
Reviews (1) · Last reviewed commit: "release notes and search-quality descrip..." · Reviewed by Greptile