land: created-file-syntax-line

[aft-alfonso]

Accepted agent delivery; branch-keyed search descriptor included.

---

Summary by cubic

write, edit, and apply_patch now report the first syntax-error line when they create a file that doesn't parse, telling the agent the new file was written as given. Existing files still roll back as before, and new Swift files that swiftc -parse accepts get no notice.

• apply_patch tracks created files and checks each one's final content once after all hunks, so later hunks that fix, break, move, or delete a new file update or remove the notice and metadata.files.syntax_error_line accordingly.
• The notice appears directly under the reply line that created the file, and broken new files are never rolled back.
• apply_patch metadata relative paths now resolve through root aliases (Unix symlink roots and Windows short names), including for files that a hunk deleted or moved away; the Windows alias test skips volumes where 8.3 short names are disabled.

^{Written for commit 841c368. Summary will update on new commits.}

Confidence Score: 5/5

The PR appears safe to merge; no new actionable issue remains.

Summary

Adds first-error lines for newly created files that do not parse.

• New files that fail syntax checks now show the first error line.
• Patches report syntax errors from each created file's final contents.
• Patch metadata stays project-relative when paths use root aliases.

Both earlier threads were manually resolved without explanation. The current code addresses both: later hunks retain final syntax details, and the Windows test skips volumes without distinct short names.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Write or format file] --> B{Created by this call?}
  B -->|No| C[Keep existing syntax rollback]
  B -->|Yes| D[Check final content]
  D --> E{Swift parser disagreement?}
  E -->|Yes| F[Confirm with swiftc]
  E -->|No| G{Syntax error remains?}
  F --> G
  G -->|Yes| H[Keep file and report first error line]
  G -->|No| I[Reply without syntax notice]

Loading

_{Reviews (6) · Last reviewed commit: "apply_patch alias test: skip on Windows ..." · Reviewed by Greptile}