Skip to content

land: blank-runon-is-local - #495

Queued
aft-alfonso[bot] wants to merge 1 commit into
mainfrom
land/blank-runon-is-local
Queued

aft-alfonso[bot] wants to merge 1 commit into
mainfrom
land/blank-runon-is-local

Conversation

@aft-alfonso

@aft-alfonso aft-alfonso Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Accepted agent delivery; branch-keyed search descriptor included.


Summary by cubic

Treats a blank runon in bash commands as a local run instead of forwarding it, so the bash handler no longer refuses those calls as remote runs. Some models fill every optional parameter and send runon: "" on local commands like git status, which were previously rejected with 'runon cannot be combined with sandbox: "host"'.

  • A runon containing only whitespace is also treated as blank; a real value like linux,4c is forwarded unchanged.
  • Adds a test covering blank and whitespace runon values, a release note entry, and a search benchmark fixture.

Written for commit 38b4c19. Summary will update on new commits.

View guided diff Turn on auto-fix

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Treats empty or whitespace-only runon values like an omitted value, avoiding remote-run refusals for ordinary bash calls.

  • Blank runon values now run bash commands locally.

Reviews (4) · Last reviewed commit: "bash: treat an empty runon as a local co..." · Reviewed by Greptile

@ualtinok
ualtinok added this pull request to the merge queue Oct 17, 2026
Any commits made after this event will not be merged.
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 17, 2026
@ualtinok
ualtinok enabled auto-merge October 17, 2026 21:07
@ualtinok
ualtinok disabled auto-merge October 17, 2026 21:09
@ualtinok
ualtinok enabled auto-merge October 17, 2026 21:09
@ualtinok
ualtinok force-pushed the land/blank-runon-is-local branch from 5ff93a4 to 53b0d2b Compare October 17, 2026 21:11
@ualtinok
ualtinok added this pull request to the merge queue Oct 17, 2026
Any commits made after this event will not be merged.
@ualtinok
ualtinok removed this pull request from the merge queue due to a manual request Oct 17, 2026
@ualtinok
ualtinok added this pull request to the merge queue Oct 17, 2026
Any commits made after this event will not be merged.
@ualtinok
ualtinok removed this pull request from the merge queue due to a manual request Oct 17, 2026
@ualtinok
ualtinok added this pull request to the merge queue Oct 18, 2026
Any commits made after this event will not be merged.
@ualtinok
ualtinok removed this pull request from the merge queue due to a manual request Oct 18, 2026
@ualtinok
ualtinok force-pushed the land/blank-runon-is-local branch from 53b0d2b to 2f4ca64 Compare October 18, 2026 01:13
@ualtinok
ualtinok added this pull request to the merge queue Oct 18, 2026
Any commits made after this event will not be merged.
Some models fill every optional parameter and send runon: "" on local
commands such as git status. The translator forwarded it, so the bash
handler read it as a remote request and refused every such call with
'runon cannot be combined with sandbox: "host"'. A blank demand names no
machine, so it now means local.

Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
@ualtinok
ualtinok removed this pull request from the merge queue due to a manual request Oct 18, 2026
@ualtinok
ualtinok force-pushed the land/blank-runon-is-local branch from 2f4ca64 to 38b4c19 Compare October 18, 2026 01:34
@ualtinok
ualtinok added this pull request to the merge queue Oct 18, 2026
Any commits made after this event will not be merged.
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 18, 2026
@ualtinok
ualtinok added this pull request to the merge queue Oct 18, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant