Use std::as_const instead of qAsConst#61
Merged
Conversation
Contributor
Author
|
Well std::as_const is C++17 not C++11 Would it be considered to bump compiler minimal version to C++17 ? |
Collaborator
|
I would say yes, it's time to require C++17, just like Qt 6 (and KDSoap) already do. |
Collaborator
|
Can you include a change to the toplevel CMakeLists.txt's CMAKE_CXX_STANDARD then? |
qAsConst is now deprecated And bump CMAKE_CXX_STANDARD version to 17.
meven
force-pushed
the
meven/fix-warnings
branch
from
ba6bdb7 to
7a91684
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qAsConst is now deprecated