Repository navigation
Update to Swift 6.4 - #115
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c094f7d13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| selected = str(swiftly) if swiftly.is_file() else shutil.which("swift") | ||
| if not selected: | ||
| raise ValueError(f"install Swift {config['minimumVersion']} with Swiftly or set SWIFT_BIN") | ||
| executable = Path(shutil.which(selected) or selected).absolute() |
There was a problem hiding this comment.
When the documented SWIFT_BIN override points to a symlink outside the toolchain—such as /usr/local/bin/swift -> /opt/swift/usr/bin/swift—.absolute() preserves the symlink, so toolchain becomes /usr/local/bin. The following sibling checks and lib/swift lookup then reject an otherwise valid compiler or use unrelated files. Resolve the selected executable's symlink target before deriving its parent directory.
Useful? React with 👍 / 👎.
No description provided.