Repository navigation
fix: Marketplace description (<125 chars) + dry-run on detached HEAD - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The description is valid, accurately documented, and below the 125-character limit.
Review effort: Balanced
Findings: None
What changed in this PR
Shortens the action description to satisfy GitHub Marketplace’s character limit and records the release-blocking fix.
Changes:
- Reduces the description to 110 characters.
- Documents the change for v1.0.1.
| File | Description |
|---|---|
action.yml |
Provides the shorter quoted description. |
CHANGELOG.md |
Records the Marketplace compatibility fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rbg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Shortens the
action.ymldescriptionfrom 149 to 110 characters. It is quoted because it contains a colon. The CHANGELOG v1.0.1 entry notes the change.Also fixes a real bug the PR checks exposed: with
dry-run, a detached HEAD (everypull_requestcheckout) failed with "detached HEAD, branch name unavailable" because the branch-from-event fallback only ran on the push path. The branch is now computed once and passed to bothgraph buildandgraph push. It reproduced locally and is fixed: PR and detached-push cases pass, and no-event-info still fails as intended.Why
The Marketplace publish form rejects the action with "Description must be less than 125 characters", which blocks the v1.0.1 Marketplace release.
CR: EMERGENCY — release blocker found in the Marketplace publish form; CR to follow.
Evidence
yqparses the file and reports a length of 110.actionlintis clean on the test workflow that loads this action.test.yml) run 37484442527 is green on ubuntu-latest, ubuntu-24.04-arm and macos-latest. The first run failed on the dry-run bug above, which also failed PR docs: README host note uses the public app domain only #1 checks.Deployment notes
After merge, re-point the unreleased
v1.0.1tag at the mergedmain(it currently points at the v1.0.0 commit), movev1, then publish the release.Reviewer checklist