Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions e2e/virtual-servers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,45 @@ test.describe("Virtual Servers page", () => {
await expect(detailsPanel.getByText("github://repo/{owner}/{repo}")).toHaveCount(0);
});

test("filters components by source in the details panel when there are several", async ({
page,
}) => {
await routeVirtualServerTryIt(page, [
makeTryItTool(),
makeTryItTool({
id: "tool-post",
name: "slack.post_message",
originalName: "post_message",
gatewayId: MOCK_MCP_SERVER_2.id,
}),
]);
// Registered after the helper's route, so it takes precedence.
await page.route("**/v1/mcp-servers?*", async (route) => {
await route.fulfill({
status: 200,
contentType: "application/json",
body: JSON.stringify({ gateways: [MOCK_MCP_SERVER, MOCK_MCP_SERVER_2] }),
});
});

await page.goto(APP.GATEWAYS);
await page.getByRole("button", { name: "Actions for testVS" }).click();
await page.getByRole("menuitem", { name: "View details" }).click();

const panel = page.getByRole("region", { name: "testVS details" });
await panel.getByRole("tab", { name: "Components" }).click();

await expect(panel.getByRole("tab", { name: "All sources" })).toBeVisible();
await expect(panel.getByRole("tab", { name: "github-mcp" })).toBeVisible();
await expect(panel.getByRole("tab", { name: "slack-mcp" })).toBeVisible();
await expect(panel.getByText("search_issues")).toBeVisible();
await expect(panel.getByText("post_message")).toBeVisible();

await panel.getByRole("tab", { name: "slack-mcp" }).click();
await expect(panel.getByText("post_message")).toBeVisible();
await expect(panel.getByText("search_issues")).toHaveCount(0);
});

test("shows a tooltip with the full endpoint when it's truncated in the Try it tab", async ({
page,
}) => {
Expand Down
30 changes: 30 additions & 0 deletions src/components/gateways/VirtualServerDetailsPanel.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,36 @@ describe("VirtualServerDetailsPanel components list", () => {
expect(screen.getByRole("tab", { name: "Gateway A" })).toHaveFocus();
});

it("hides the source selector when the server has a single source", async () => {
const user = userEvent.setup();
mswServer.use(
http.get("*/v1/virtual-servers/:id/tools", () =>
HttpResponse.json({
tools: [{ id: "t1", name: "Tool One", originalName: "tool_one", gateway_id: "gwA" }],
}),
),
http.get("*/v1/mcp-servers", () =>
HttpResponse.json({ gateways: [{ id: "gwA", name: "Gateway A" }] }),
),
);

render(
<VirtualServerDetailsPanel
server={makeServer({ id: "gw-single-source" })}
error={null}
open
onClose={vi.fn()}
onAddSources={vi.fn()}
/>,
);

await user.click(await screen.findByRole("tab", { name: "Components" }));
expect(await screen.findByText("tool_one")).toBeInTheDocument();

expect(screen.queryByRole("tab", { name: "All sources" })).not.toBeInTheDocument();
expect(screen.queryByRole("tab", { name: "Gateway A" })).not.toBeInTheDocument();
});

it("moves the active tab with arrow keys", async () => {
const user = userEvent.setup();
renderWithComponents();
Expand Down
6 changes: 2 additions & 4 deletions src/components/gateways/VirtualServerDetailsPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,7 @@ export function VirtualServerDetailsPanel({
return `/v1/mcp-servers?${params}`;
}, []);

const { data: sourcesData, isLoading: sourcesLoading } = useQuery<
MCPServersResponse | MCPServer[]
>(sourcesPath, {
const { data: sourcesData } = useQuery<MCPServersResponse | MCPServer[]>(sourcesPath, {
enabled: fetchEnabled && sourceIds.length > 0,
});

Expand Down Expand Up @@ -637,7 +635,7 @@ export function VirtualServerDetailsPanel({
/>
) : (
<>
{(sourcesLoading || sourceTabs.length > 0) && (
{sourceTabs.length > 1 && (
<div
role="tablist"
aria-label={intl.formatMessage({ id: "gateways.details.filterSources" })}
Expand Down
Loading