balloons: fix publishing PCT HP CPU cores as extended resources#711
Merged
fmuyassarov merged 2 commits intoJun 29, 2026
Merged
Conversation
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Collaborator
Author
|
@marquiz, I broke this feature in a last-minute "fix" before release (f206c26), didn't have regression test for it, and trusted that it would work without giving it a shot in a real system. As a last commit and with all these red flags it was easy to spot. What a stupid error in both the code and the process... |
marquiz
approved these changes
Jun 29, 2026
marquiz
left a comment
marquiz
left a comment
Collaborator
There was a problem hiding this comment.
Ach, sorry about my last-minute churn 😬
LTM
Collaborator
Author
|
It was a good point. Only the implementation and the process sucked. 😖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.