deps: raise the buffa floor to 0.9.2 and regenerate checked-in code - #294
Merged
Merged
Conversation
buffa 0.9.2 (2026-09-03) changes codegen output: generated `decode_view` attaches the element-memory budget, view decoders merge split map values, enums carry `#[allow(non_camel_case_types)]`, and `SizeCache` panics are gated on debug assertions. The workspace has no committed lockfile, so CI's generated-code check resolved 0.9.2 as soon as it was published and has failed on every PR since, because the checked-in files were 0.9.1 output. This regenerates all six checked-in directories with the 0.9.2 plugins and moves the floor to match the regen baseline, as the workspace comment asks. Signed-off-by: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
iainmcgin
force-pushed
the
iain/regen-buffa-0.9.2
branch
from
September 5, 2026 23:12
8ff700b to
6e7d0df
Compare
iainmcgin
marked this pull request as ready for review
September 6, 2026 15:09
rpb-ant
approved these changes
Sep 11, 2026
iainmcgin
added a commit
to allada/connect-rust
that referenced
this pull request
Sep 24, 2026
Stacked on connectrpc#294 (the first commit here is that PR; this one rebases onto main once it lands). With no committed lockfile, a dependency release changed what CI built overnight: the generated-code check resolved the newest buffa at run time and has failed on every PR since buffa 0.9.2 changed codegen output on 2026-09-03, and the MSRV job is exposed the same way to any transitive MSRV bump. This commits the workspace `Cargo.lock` (resolved against crates.io today, buffa 0.9.2) and builds CI with `--locked` (the example scripts and `task generate:all` add it when `CI` is set), so a dependency bump becomes an explicit PR; the generated-code job builds the buffa plugins from the tag matching the locked version, so a buffa bump and its regenerated code have to travel together. Two companions keep the lock from going stale: a weekly Dependabot group PR for semver-compatible updates, and a scheduled *Latest dependencies* workflow that runs the tests after a fresh `cargo update`, which is what a crate depending on `connectrpc` resolves — the lockfile itself has no effect on those crates. `--locked` also passes on the 1.88 MSRV toolchain (lockfile format v4). Fixes connectrpc#254 (the "related" `buf.gen.yaml` sibling-checkout note there is not addressed). Signed-off-by: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffa 0.9.2 shipped on 2026-09-03 and changes codegen output (generated
decode_viewattaches the element-memory budget, view decoders merge split map values, generated enums carry#[allow(non_camel_case_types)]), and because the workspace has no committed lockfile the Check generated code job resolved 0.9.2 immediately and has failed on every PR since — #293 is the first to show it. This regenerates the five checked-in directories with the 0.9.2 plugins and raises the floor to match the regen baseline; code generated by 0.9.1 still compiles against 0.9.2, so the floor is for the hardening fixes and the baseline rather than a compile requirement. A secondtask generate:allafter this commit is a no-op.