Repository navigation
fix: oracle staleness, multi-asset aggregation, RBAC events, pause cooldown - #801
Merged
Jaydbrown merged 1 commit intoOct 18, 2026
Conversation
…ing, pause cooldown - conduit-protocol#777: Add OraclePriceStale (16) error for timestamp exceeding heartbeat interval - conduit-protocol#778: Add multi-asset price feed aggregation tests with deviation bounds checking across independent oracle buffers and price tolerance ranges - conduit-protocol#779: Add role revocation event logging via revoke_with_event function emitting RoleRevokedEvent; add multi-admin guards tests verifying final admin protection and members list preservation across revocations - conduit-protocol#780: Implement unpause cooldown period in pause.rs; set_paused_with_cooldown prevents rapid toggle attacks by enforcing cooldown between unpause and re-pause
|
@0xpreshh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four contract fixes across oracle, RBAC, and pause modules.
#777 — OraclePriceStale error for heartbeat interval violations
Added error variant
OraclePriceStale = 16to catch timestamp violations exceeding the asset's configured heartbeat interval. Supports use cases where oracles must refresh prices within a strict window.#778 — Multi-asset price feed aggregation with deviation bounds
Added test suite for aggregating prices across independent oracle buffers for multiple assets, validating that deviation checks work correctly:
multi_asset_aggregation_with_independent_buffers: assets maintain separate observation queuesdeviation_bounds_reject_excessive_spread: spread beyond tolerance returns errordeviation_bounds_accept_within_tolerance: spread within tolerance accepted#779 — RBAC role revocation event logging and multi-admin guards
RoleRevokedEventstruct andrevoke_with_eventfunction that emits events on role revocationrevokewrapper for existing call sitesmulti_admin_prevents_revocation_of_last_admin: prevents governance freezemulti_admin_guards_preserve_members_list: members list consistency across revocations#780 — Unpause cooldown period to prevent rapid toggle attacks
PauseStatewithunpaused_atandunpause_cooldownfieldsset_paused_with_cooldownthat enforcesnow >= last_unpaused_at + cooldown_secondsbefore re-pausingErr(PausedError::ContractPaused)if cooldown still activeunpause_cooldown_prevents_rapid_re_pauseverifies attack preventionCloses #777
Closes #778
Closes #779
Closes #780