Repository navigation
Add contract validation enhancements across stream, token-vault, and factory - #800
Merged
Jaydbrown merged 1 commit intoOct 18, 2026
Conversation
## Summary Implements four critical contract validation improvements: ### conduit-protocol#785 - StreamCancelled event includes remaining deposit - Added remaining_deposit parameter to cancelled() and force_cancelled() events - Provides complete financial breakdown in event logs - Updated lib.rs calls to pass refund_to_sender as remaining_deposit ### conduit-protocol#786 - SEP-0041 transfer return value validation - Validates return values from all tk.transfer() calls in token-vault - Maps transfer errors to appropriate contract errors - Catches transfer failures before state mutations - Affects 5 transfer points in lib.rs ### conduit-protocol#787 - Duplicate stream ID validation in batch cancel - Added DuplicateStreamId error code (33) to factory errors - Validates non-duplicate stream addresses before batch processing - Uses Map-backed set for O(log n) duplicate detection - Rejects batch early if duplicates detected ### conduit-protocol#788 - WASM hash registry verification - Validates WASM hash exists in Soroban ledger before deployment - Uses env.ledger().get_wasm() to verify registry - Prevents deployment failures from stale/invalid hashes - Early validation in deploy_stream() Closes conduit-protocol#785 Closes conduit-protocol#786 Closes conduit-protocol#787 Closes conduit-protocol#788
|
@SarahDoma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#785 — StreamCancelled event includes remaining deposit
#786 — Validate SEP-0041 transfer return values before updating state
#787 — Validate non-duplicate stream IDs in batch cancel payload
#788 — Verify WASM hash registry prior to instantiating new stream contracts
Closes #785
Closes #786
Closes #787
Closes #788