Skip to content

contracts/stream/src/errors.rs: add ZeroRateStreamNotAllowed error variant #792

Closed

Description

@Jaydbrown

Context

Creating a stream where duration is vastly larger than amount yields a rate of 0 tokens per second.

Why it matters

Zero-rate streams waste contract addresses and can never disburse tokens to recipients.

Suggested approach

Add ZeroRateStreamNotAllowed = 22 error and reject streams where deposit / duration == 0.

Activity

  1. sampapiz commented on Oct 17, 2026

    @sampapiz

    @sampapiz has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I’d like to implement this validation to prevent zero-rate streams and wasted contract addresses. I’d appreciate the opportunity to contribute a reliable fix.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @sampapiz to this issue.

  2. EmmanuelOchaje commented on Oct 18, 2026

    @EmmanuelOchaje
    Contributor

    @EmmanuelOchaje has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hi there let me fix this

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @EmmanuelOchaje to this issue.

  3. drips-wave commented on Oct 18, 2026

    @drips-wave

    Congratulations, @EmmanuelOchaje! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @EmmanuelOchaje: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. grantfox-oss commented on Oct 18, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @EmmanuelOchaje's PR #798 was approved and merged by @Jaydbrown.

    🏆 @EmmanuelOchaje: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (681 total points). Track your full progress on GrantFox.

    👏 Great work, @EmmanuelOchaje! Keep contributing to conduit-protocol.

  5. drips-wave commented on Oct 18, 2026

    @drips-wave

    This issue has been completed by @EmmanuelOchaje as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @EmmanuelOchaje: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programenhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions