Skip to content

fix: use secondary button#252

Merged
gusfcarvalho merged 1 commit into
mainfrom
gc-fix-send-notification-button
May 28, 2026
Merged

fix: use secondary button#252
gusfcarvalho merged 1 commit into
mainfrom
gc-fix-send-notification-button

Conversation

@gusfcarvalho
Copy link
Copy Markdown
Contributor

@gusfcarvalho gusfcarvalho commented May 28, 2026

Summary by CodeRabbit

Release Notes

  • Style
    • Improved visual consistency of the "Send test notification" button in the admin notifications interface.

Review Change Stack

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
@gusfcarvalho gusfcarvalho enabled auto-merge (squash) May 28, 2026 13:58
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f6240cfa-29e7-46c3-a762-8e6d705b64dd

📥 Commits

Reviewing files that changed from the base of the PR and between 1a07d9c and a08d126.

📒 Files selected for processing (1)
  • src/views/admin/NotificationsView.vue

📝 Walkthrough

Walkthrough

This PR refactors the "Send test notification" button in NotificationsView from a plain HTML <button> element to the shared SecondaryButton component, applying text-sm styling while preserving the disabled binding tied to the test-send loading state.

Changes

UI Component Consistency

Layer / File(s) Summary
Send test notification button component
src/views/admin/NotificationsView.vue
The "Send test notification" trigger is refactored from a plain HTML <button> to the SecondaryButton component with text-sm styling and preserved disabled binding. Opening and closing tags are updated to match the component swap.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A button once plain, now wears a new coat,
SecondaryButton carries the note,
Test notifications sail with consistent grace,
Component reuse wins the race! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: replacing an HTML button with the SecondaryButton component in the NotificationsView.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@gusfcarvalho gusfcarvalho merged commit fad4a38 into main May 28, 2026
2 of 3 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-fix-send-notification-button branch May 28, 2026 14:00
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant