Skip to content

fix: supports disable agent public endpoints via env vars#412

Merged
gusfcarvalho merged 1 commit into
mainfrom
gc-fix-strict-disable-via-env-vars
Jun 3, 2026
Merged

fix: supports disable agent public endpoints via env vars#412
gusfcarvalho merged 1 commit into
mainfrom
gc-fix-strict-disable-via-env-vars

Conversation

@gusfcarvalho
Copy link
Copy Markdown
Contributor

@gusfcarvalho gusfcarvalho commented Jun 3, 2026

Summary by CodeRabbit

  • New Features
    • Added a new configuration setting to control public agent endpoints via the CCF_STRICT_DISABLE_PUBLIC_AGENT_ENDPOINTS environment variable (default: disabled).

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copilot AI review requested due to automatic review settings June 3, 2026 12:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f61b4658-1462-459e-8a0e-7c613f9a8adb

📥 Commits

Reviewing files that changed from the base of the PR and between 4d3edbc and d703d83.

📒 Files selected for processing (2)
  • cmd/root.go
  • internal/config/config.go

📝 Walkthrough

Walkthrough

A new configuration setting strict_disable_public_agent_endpoints is added to the CLI system with a default value of "false" and bound to the environment variable CCF_STRICT_DISABLE_PUBLIC_AGENT_ENDPOINTS. The setting is read from Viper into the Config struct during initialization.

Changes

Configuration Setting Support

Layer / File(s) Summary
CLI configuration wiring and Config struct initialization
cmd/root.go, internal/config/config.go
Default value and environment variable binding for strict_disable_public_agent_endpoints are added to CLI setup. The setting is read from Viper into a local variable and assigned to the Config struct.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A new setting hops into place,
With defaults and env vars in grace,
Strict endpoints now bound,
Configuration found,
Our config takes form at its base!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: adding support for disabling agent public endpoints via environment variables, which is reflected in both modified files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@gusfcarvalho gusfcarvalho merged commit 4e9fe14 into main Jun 3, 2026
5 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-fix-strict-disable-via-env-vars branch June 3, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants