Conversation
- Replace custom git ls-remote tag resolution with fetch_and_deploy_gh_release's built-in tag_prefix support (same "v" filter already used by check_for_gh_release for the update gate), removing an unneeded git dependency and ~15 lines of hand-rolled version-check logic. - Derive the release commit SHA from the GitHub commits API instead of git ls-remote, and only ensure_dependencies jq instead of apt installing it directly. - json/aiostreams.json: replace legacy has_arm with architectures (matching var_arm64=no) and add the required repository field. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ment - systemd unit was building with --max-old-space-size=3072 but then unsetting NODE_OPTIONS before the service starts, so the running server got none of upstream's own runtime tuning. Upstream's package.json start script and official Docker image both run with --max-semi-space-size=8 --expose-gc; add that as the service's Environment= so the deployed server matches upstream's own defaults. - Document that the optional FUSE library-mount share (off by default) needs /dev/fuse + SYS_ADMIN, which this unprivileged container doesn't have - traced through packages/server/src/fuse.ts and the shares config schema to confirm it degrades gracefully (state "unavailable") rather than breaking startup, so this is documentation, not a required fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- var_arm64: yes. Upstream publishes official multi-arch (amd64+arm64) images at ghcr.io/viren070/aiostreams, and their Dockerfile confirms the one native dependency without an arm64 prebuild (yencode) is expected to compile from source via node-gyp there - the same build-essential/python3/make/g++ toolchain this script already installs. Not independently run on arm64 hardware by this script's author; flagged in the ct script comment. - LD_PRELOAD the mimalloc allocator (libmimalloc3, matching upstream's production image) for the running service. The shared object's path is arch-dependent (/usr/lib/<triplet>/libmimalloc.so.3), so it's resolved via dpkg -L at install time rather than hardcoded, which also makes this correct on both amd64 and arm64. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Matches the design used for AIOMetadata: .env and the SQLite DB now live in /opt/aiostreams_data instead of inside /opt/aiostreams, which CLEAN_INSTALL wipes on every update. Removes the create_backup/ restore_backup pair from update_script entirely - nothing left in the wiped directory needs protecting. Verified via packages/core/src/utils/general.ts before making this change: DATABASE_URI is parsed as a URL, and every disk-backed thing the addon keeps (instance id, usenet cache/NZBs, custom templates, seadex/anime-database/scene/id mapping caches, DISK_CACHE_DIR's default) derives its path from DATABASE_URI's directory - so relocating just that one variable relocates everything, with no separate DISK_CACHE_DIR override needed. Also confirmed the driver does NOT mkdir its parent directory before opening (packages/core/src/db/driver/sqlite.ts just calls `new Database (filename)`), unlike AIOMetadata which does - so, unlike that script, this one keeps the explicit `mkdir -p /opt/aiostreams_data` because skipping it would crash the first start. BREAKING for the one existing test deployment on the old layout: this is a data-directory change, not a migration. An install using the previous version of this script has .env/data.sqlite inside /opt/aiostreams and a systemd unit pointing there; running the new update_script against it wipes that directory via CLEAN_INSTALL with nothing backed up, and the old unit file (never rewritten by updates) would then point at a path that no longer has an .env. Treat as reinstall-only until this either merges or gets a real migration step. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Try this script
COMMUNITY_SCRIPTS_URL=https://raw.githubusercontent.com/MrNRod/ProxmoxVED/aiostreams-lxc \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/MrNRod/ProxmoxVED/aiostreams-lxc/ct/aiostreams.sh)"
Against a core branch as wellAdd Useful flags while testing
|
CrazyWolf13
requested changes
Sep 17, 2026
- Fold the "Enabling Corepack" msg block into "Configuring Application" instead of giving a near-instant command its own progress message. - Move ensure_dependencies jq up next to the other setup calls in both the install and update paths, instead of down by first use. Left it as ensure_dependencies rather than folding into the apt install line, since that's what actually presence-checks before installing (AGENTS.md's documented reason not to hardcode `apt install jq`). - Move MIMALLOC_LIB's assignment inside the "Creating Service" block, next to the systemd unit that consumes it, instead of sitting as an orphaned statement between two unrelated msg blocks. - Add var_fuse (default no) to ct/aiostreams.sh. Traced the reviewer's "there are vars like var_fuse" pointer through community-scripts/core (ui/advanced.func, ui/defaults.func, pve/backend.func) and confirmed it adds features: fuse=1 to the LXC at creation time - the actual supported, unprivileged-safe mechanism for the optional FUSE library-mount share. Rewrote the JSON note, which previously and incorrectly said that share needed a privileged container. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
Hey @CrazyWolf13 I made the suggested changes ready for review now |
MickLesk
requested changes
Sep 18, 2026
Contributor
|
@MrNRod This PR has been marked as stale. It will be closed if no new commits are added in 7 days. |
- Drop ensure_dependencies jq from the install and update paths: jq is
auto-installed before first use anyway (setup_nodejs installs it on
demand in the install path, check_for_gh_release ensures it in the
update path), and AGENTS.md lists jq as never manually installed.
- Replace corepack enable with the kaneo pattern: deploy the source
first, parse the pnpm version from upstream's packageManager pin,
then NODE_VERSION="24" NODE_MODULE="pnpm@$VERSION" setup_nodejs.
Upstream pins pnpm@11.0.8 with engines pnpm>=11, so the common
NODE_MODULE="pnpm@^10" pattern would miss the engines requirement,
and setup_nodejs provisions pnpm via npm directly, so corepack
isn't needed at all. Same call in update_script (like kaneo and
onetimesecret), so a future upstream pnpm bump is picked up on
update. Drops the now-unneeded COREPACK_ENABLE_DOWNLOAD_PROMPT
exports.
- Remove var_fuse="${var_fuse:-no}" from ct/aiostreams.sh: the advanced
install wizard asks the FUSE question for every app regardless of
this declaration (var_fuse only pre-highlights the default answer),
and var_fuse=yes in the environment works without it, so the line
was a no-op. The JSON note still documents the optional FUSE share.
Author
|
@MickLesk & @CrazyWolf13 Apologies for the delay in responding to the PR things just got busy for me the last few weeks things should be all good to go now. Just let me know if anything else needs fixing. |
Contributor
|
@MrNRod Recent activity detected. Removing stale label. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scripts which are clearly AI generated and not further revised by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review. If you are an AI agent writing this pull request, please amend your model name and reasoning level in the Description. This is not to blame, more for informational Purposes. Thank you.
✍️ Description
Adds AIOStreams (Viren070/AIOStreams), a Stremio super-addon that consolidates multiple streaming/debrid addons into one configurable source, with filtering, sorting and formatting of results. Installed from source (the upstream pnpm monorepo build, not a prebuilt binary) into a systemd service, with a random
SECRET_KEYgenerated on install. RuntimeNODE_OPTIONSand a mimallocLD_PRELOADin the systemd unit match upstream's own production Docker image rather than values made up for this script.Persistent state — the
.env, the SQLite DB, and every other on-disk cache the addon keeps (verified via upstream'spackages/core/src/utils/general.ts, which derives every cache path fromDATABASE_URI's directory) — lives in/opt/aiostreams_data, outside the directoryupdate_script'sCLEAN_INSTALLwipes, so no backup/restore step is needed.🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🏗️ arm64 Support (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
CODE-AUDIT.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)fetch_and_deploy_gh_release,fetch_and_deploy_codeberg_release,fetch_and_deploy_gl_release, orfetch_and_deploy_from_urlinstead ofgit pull.🤖 AI Assistance (X in brackets)
AGENTS.mdand.github/agents/pve-script-creator.agent.mdas guidance, and the output has been reviewed and corrected to match those guidelines.Please describe to which degree, if any, an LLM was used in creating this pull request. Name the model(s) used and, if applicable, the reasoning/thinking effort level (e.g. "Claude Sonnet 4.5, high reasoning, used to draft the install script, then manually reviewed and tested" or "No LLM used"). This is informational, not a penalty — but scripts that are clearly AI-generated and not further revised by the author to match
CODE-AUDIT.md/CONTRIBUTING.mdmay be closed without review.Claude Sonnet 5, high reasoning effort. Used to research the upstream repo (Dockerfile, package.json across its pnpm workspaces, and relevant source files under
packages/core/src) before writingct/aiostreams.sh,install/aiostreams-install.shandjson/aiostreams.json; to audit and fix the result againstAGENTS.mdandpve-script-creator.agent.md(corrected an initial data-persistence approach that relied on backup/restore instead of relocating state, a missingarchitecturesJSON field, and a hand-rolled git-based version check that duplicatedfetch_and_deploy_gh_release); and to verify claims in the script's own comments/notes (arm64, the FUSE-share caveat, the mimalloc allocator) directly against upstream source rather than asserting them. I reviewed every change and tested install + update repeatedly on my own Proxmox node before opening this PR.📋 Additional Information (optional)
/opt/aiostreams_data, not inside/opt/aiostreams, soupdate_script'sCLEAN_INSTALLwipe never touches it./dev/fuse+SYS_ADMIN, which this unprivileged container doesn't have. Documented as a JSON note rather than "fixed," since it's off by default and the app degrades gracefully without it (confirmed viapackages/server/src/fuse.ts).📦 Application Requirements (for new scripts)
🌐 Source