hardwared: ignore invalid thermal readings - #39014
Closed
ousamabenyounes wants to merge 1 commit into
Closed
ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36690.\n\n## Summary\n- return NaN for thermal-zone read errors so failed readings stay visible in logs\n- keep the existing zero fallback for absent thermal zones\n- ignore non-finite temperatures when deriving thermal-status/fan inputs so a failed sensor read does not poison downstream filters\n\n## Tests\n- RED:
PYTHONPATH=$BASE_WT uv run --frozen --with pytest python -m pytest -q openpilot/common/tests/test_hardware_thermal.pyon base failed withImportError: cannot import name 'max_valid_temperature'\n- GREEN:PYTHONPATH=$THERMAL_WT uv run --frozen --with pytest python -m pytest -q openpilot/common/tests/test_hardware_thermal.py-> 3 passed\n-PYTHONPATH=$THERMAL_WT uv run --frozen --with ruff ruff check openpilot/common/hardware/base.py openpilot/system/hardware/hardwared.py openpilot/common/tests/test_hardware_thermal.py-> passed\n