Stop using Travis CI and switch to GitHub Actions - #77
Open
willnet wants to merge 4 commits into
Open
Conversation
Modern minitest only defines Minitest::Test (lowercase "test"); the old MiniTest::Test spelling raises NameError, which was breaking the suite on newer Ruby/minitest combinations. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Extends the existing test/gemfiles/*.gemfile pattern (one gemfile per minor Rails release, pinning actionpack) to cover the currently supported Rails lines, up from the previous 5.0-5.2 only set. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Runs the test suite across the ruby/gemfile pairs each Rails line actually supports (per fastruby.io's compatibility table), plus experimental (allow-failure) legs on Ruby 4.0/head for the still maintained Rails 8.0/8.1 lines. Also ignores the local *.gemfile.lock files bundler generates per gemfile. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Two dependency-resolution issues broke every Rails 6.0/6.1 leg and every Ruby 2.3/2.4 leg: * concurrent-ruby 1.3.5 dropped its `require "logger"`, which ActiveSupport relied on until 7.1, so loading it raised NameError on ActiveSupport::LoggerThreadSafeLevel::Logger. * loofah 2.21.1 needs Nokogiri::HTML4 (nokogiri >= 1.12, hence Ruby >= 2.5) while only declaring nokogiri >= 1.5.9, so bundler picked it alongside nokogiri 1.10 on Ruby 2.3/2.4 and loading it raised NameError on Nokogiri::HTML4. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously used Travis CI conveniently, but as of 2024, using Travis CI to build OSS requires contacting them to get a fixed amount of credits each month, making it cumbersome. I want to reduce the hassle by migrating from Travis CI to GitHub Actions.
As part of the migration to GitHub Actions, I've configured CI to support Ruby and Rails up to their latest versions.
Some tests failed due to dependency-related issues, but I'm resolving them all so they pass.
Here are the test results