Repository navigation
Fix vscode-languageserver node import for v10 exports map - #8
Merged
fsoikin merged 1 commit intoJun 3, 2026
Merged
Conversation
vscode-languageserver 10.0.0 introduced an exports map that only exposes the node entry under the ./node subpath. The FFI imported it as vscode-languageserver/node.js, which is not a key in the exports map, so esbuild fails to bundle: Could not resolve "vscode-languageserver/node.js" The path "./node.js" is not exported by package "vscode-languageserver" Because the package declares no dependency pin, the whine bootstrap npm install resolves the latest vscode-languageserver (now 10.x), breaking the cached-bundle build for every consumer. Drop the .js suffix so the import matches the ./node export key. This resolves on v10 (matches ./node) and stays compatible with v9.0.1 (no exports map; resolves to the root node.js file).
fsoikin
approved these changes
Jun 3, 2026
fsoikin
left a comment
fsoikin
left a comment
Contributor
There was a problem hiding this comment.
Sure, looks good, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vscode-languageserver 10.0.0 introduced an exports map that only exposes the node entry under the ./node subpath. The FFI imported it as vscode-languageserver/node.js, which is not a key in the exports map, so esbuild fails to bundle:
Because the package declares no dependency pin, the whine bootstrap npm install resolves the latest vscode-languageserver (now 10.x), breaking the cached-bundle build for every consumer.
Drop the .js suffix so the import matches the ./node export key. This resolves on v10 (matches ./node) and stays compatible with v9.0.1 (no exports map; resolves to the root node.js file).