Merge providence MetaTagManager code - #183
Open
Monica-Wood wants to merge 1 commit into
Open
Conversation
Owner
|
A solution to the problem you note will have to be devised before this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from Pull Request #178
Bringing in the changes to MetaTagManager from Providence.
A word of caution:
Unlike previous code and the changes I originally suggested, this update will not overwrite tags with a new value, but continue to add the values into an array. Only way to remove values currently is through the use of
MetaTagManager::clearAll();.I foresee there might be prior use of
addMeta()andaddMetaProperty()in themes that utilised this behaviour and didn't useclearAll()( I can see themes in this repository that does so).