Repository navigation
Expand library test coverage to ~86% - #12
Merged
Merged
Conversation
Drives a connected client through room detail, capacity/stage/option/ item/title changes, tank/team select, ready, user lookup, avatar get/set/buy(gold+cash), sell, gift, and kick — the handlers the create/join/chat flows don't reach.
Runs a battle in each game mode (distinct secondary tanks so Tag can swap) through firing and a death, rendering every frame — covering the mode-specific simulation and render paths.
Constructs DialogWidget, CreateRoomDialogWidget, BuddyChatWindowWidget, AddBuddyDialogWidget, and BuddyPanelWidget with fake textures and drives draw plus a spread of clicks, text, keys, and drags over their frames.
With no archives on disk, every loader surfaces a missing-archive error and localizedString degrades to nil.
The buddy/chat tests depended on a real push round-trip through onEnter's concurrent request fan-out, which intermittently starved a handshake on CI (timeout(nonceResponse)). They now drive the network send (covering the Task body) and apply the resulting push directly, covering applyBuddyList/appendChat deterministically — the real round-trip is still exercised by the loopback suite. Also bumps connect retries (4->10) and the wait window for extra CI margin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the library coverage work merged in #11, pushing overall library coverage to ~86% (from ~84% at the merge point). All CI jobs green; the suite stays deterministic.
InBattleScreento resolution (distinct secondary tanks so Tag can swap), covering the mode-specific simulation and render paths.DialogWidget,CreateRoomDialogWidget,BuddyChatWindowWidget,AddBuddyDialogWidget,BuddyPanelWidgetwith fake textures and drives draw + a spread of clicks/text/keys/drags.localizedStringdegrades tonil.applyBuddyList/appendChatdeterministically — the real round-trip stays exercised by the loopback suite. Also bumps connect retries and the wait window for CI margin.Coverage
Test plan
swift test— 554 tests, green across repeated local runs (~14s)