refactor(neotree): reuse native husk standard library#152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Neo-tree still performs path normalization, Git-status decoration, and tree-row construction through compatibility helpers even though Husk now has a native standard library. Moving the pure presentation work into a native package makes it typed and directly testable while keeping permissioned filesystem actions and confirmations in the existing shell.
What Changed
plugins/neotree_corepackage for normalized paths, typed status presentation, selection and clipboard markers, icons, and bounded tree renderingplugins/neotree.hkwhile preserving workspace confinement, destructive-action confirmations, directory truncation, and the 200-row instruction-budget guardHow to Test
Run the focused native and runtime regressions:
All tests should pass, including filesystem-root repositories, create/delete flows, large Git-status listings, and pathological directory listings capped at 200 rows.
Verify the bundled runtime and lint gate:
The self-check should report
plugin neotree: activeand finish successfully.