[DEV-387] Add GPG signing infrastructure for Homebrew tap trust - #6
Draft
YairLeshemOctopus wants to merge 1 commit into
Draft
[DEV-387] Add GPG signing infrastructure for Homebrew tap trust#6YairLeshemOctopus wants to merge 1 commit into
YairLeshemOctopus wants to merge 1 commit into
Conversation
- Add comprehensive SIGNING.md documentation for GPG setup
- Create BOT_SETUP.md guide for configuring bot accounts with GPG
- Add CONTRIBUTING.md with GPG signing requirements
- Create .trusted-keys file to track authorized signers
- Add example GitHub Actions workflows in .github/workflows-examples/:
- sign-commits.yml: Sign existing commits with GPG
- update-formula.yml: Automated formula updates with signing
- verify-signatures.yml: Verify all commits are GPG-signed
- Add verify-signatures.sh script for local signature verification
- Add PR template with GPG signing checklist
- Update README.md with tap trust information and instructions
This implements tap signing to make codefresh-io/cli trusted in Homebrew.
Homebrew 5.2.0/6.0.0 will require tap trust verification by default.
Addresses the warning:
Warning: The following taps are not trusted:
codefresh-io/cli
Workflow files are provided as examples in .github/workflows-examples/
because adding workflows requires a token with 'workflow' scope.
See .github/workflows-examples/README.md for activation instructions.
Linear issue: https://linear.app/octopus/issue/DEV-387/codefresh-io-cli-tap-is-not-trusted-in-homebrew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue: https://linear.app/octopus/issue/DEV-387/codefresh-io-cli-tap-is-not-trusted-in-homebrew
Summary
This PR implements GPG signing infrastructure to make the Homebrew tap trusted. Starting with Homebrew 5.2.0/6.0.0, tap trust verification will become mandatory by default.
Problem
Homebrew currently shows this warning:
Solution
This PR adds comprehensive GPG signing infrastructure including:
Documentation
Infrastructure
GitHub Actions Workflows (Examples)
Located in
.github/workflows-examples/(requires token with 'workflow' scope to activate):Implementation Notes
Why Workflows Are Examples
The workflow files are in
.github/workflows-examples/because:workflowscopeSee
.github/workflows-examples/README.mdfor activation instructions.Next Steps for Maintainers
Review and approve this PR
Set up GPG keys for bot accounts:
BOT_GPG_PRIVATE_KEY,BOT_GPG_PASSPHRASE).trusted-keysEnable workflows (requires admin with workflow scope):
Configure existing CI/CD to sign commits (see BOT_SETUP.md)
Sign existing commits (optional but recommended):
git rebase --exec 'git commit --amend --no-edit -n -S' -i <base>Testing
After merging and configuring GPG keys, users can trust the tap:
Verify signatures:
References
cf2.rb,codefresh.rbChecklist