Skip to content

⚡️ Speed up method Algorithms.register by 57% #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Algorithms.register by 57% #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/titiler/core/titiler/core/algorithm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,16 @@ def register(
overwrite: bool = False,
) -> "Algorithms":
"""Register Algorithm(s)."""
for name, _algo in algorithms.items():
if name in self.data and not overwrite:
raise Exception(f"{name} is already a registered. Use overwrite=True.")

if not overwrite:
# Find overlap efficiently without repeated lookups in self.data
overlapping = self.data.keys() & algorithms.keys()
if overlapping:
raise Exception(
f"{next(iter(overlapping))} is already a registered. Use overwrite=True."
)

# Fast dictionary merging (Python 3.9+) via | operator would be ideal,
# but for Python 3.11, dictionary unpacking is still efficient and safe.
return Algorithms({**self.data, **algorithms})

@property
Expand Down