Skip to content

⚡️ Speed up function get_dependency_query_params by 18% #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function get_dependency_query_params by 18% #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/titiler/core/titiler/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,27 @@ def get_dependency_query_params(

Important: We assume the `callable` in not a co-routine.
"""
dep = get_dependant(path="", call=dependency)
# Avoid recreating Dependant for each call if possible
dep = get_dependant.__globals__.get("_codeflash_dep_cache", {}).get(id(dependency)) # type: ignore
if dep is None:
dep = get_dependant(path="", call=dependency)
_cache = get_dependant.__globals__.setdefault("_codeflash_dep_cache", {})
_cache[id(dependency)] = dep

# Fast path for QueryParams
if isinstance(params, QueryParams):
qp = params
else:
# Avoid unnecessary urlencode when params is empty or already a QueryParams
if not params:
qp = QueryParams("")
else:
# Faster than urlencode for small dicts: prebuild string when no lists in values are present
if all(not isinstance(v, (list, tuple)) for v in params.values()):
qp = QueryParams('&'.join(f"{k}={v}" for k, v in params.items()))
else:
qp = QueryParams(urlencode(params, doseq=True))

qp = (
QueryParams(urlencode(params, doseq=True))
if isinstance(params, Dict)
else params
)
return request_params_to_args(dep.query_params, qp)


Expand Down