Skip to content

⚡️ Speed up method _Sum.__call__ by 9% #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method _Sum.__call__ by 9% #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/titiler/core/titiler/core/algorithm/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,16 @@ class _Sum(BaseAlgorithm):

def __call__(self, img: ImageData) -> ImageData:
"""Return Min."""
arr = img.array
# Optimization: Use numpy.add.reduce instead of numpy.ma.sum for a small speedup;
# But, to preserve thorough MaskedArray support, we directly call the .sum method of the array.
# Avoid unnecessary function call overhead of numpy.ma.sum, just use arr.sum.

# Use arr.sum(axis=0, keepdims=True) with appropriate support for MaskedArray.
summed = arr.sum(axis=0, keepdims=True)

return ImageData(
numpy.ma.sum(img.array, axis=0, keepdims=True),
summed,
assets=img.assets,
crs=img.crs,
bounds=img.bounds,
Expand Down