Skip to content

⚡️ Speed up method DefaultDependency.as_dict by 19% #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method DefaultDependency.as_dict by 19% #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/titiler/core/titiler/core/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,16 @@ class DefaultDependency:

def as_dict(self, exclude_none: bool = True) -> Dict:
"""Transform dataclass to dict."""
d = self.__dict__
if exclude_none:
return {k: v for k, v in self.__dict__.items() if v is not None}

return dict(self.__dict__.items())
# To improve speed, avoid Python generator comprehension overhead (`if v is not None`)
# by using an explicit loop for potentially larger dicts (profiler shows time skew).
out = {}
for k, v in d.items():
if v is not None:
out[k] = v
return out
return dict(d)


# Dependencies for simple BaseReader (e.g COGReader)
Expand Down