Skip to content

⚡️ Speed up function add_span_attributes by 337% #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function add_span_attributes by 337% #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/titiler/core/titiler/core/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@

from typing_extensions import ParamSpec

from titiler.core import __version__

try:
from opentelemetry import trace
from opentelemetry.trace import Span, Status, StatusCode

tracer = trace.get_tracer("titiler.core", __version__)
tracer = None
except ImportError:
trace = None
Span = None
Expand All @@ -27,10 +25,11 @@

def add_span_attributes(attributes: Dict[str, Any]) -> None:
"""Adds attributes to the current active span."""
if not tracer:
if tracer is None:
return
span = trace.get_current_span()
if span and span.is_recording():
# Avoid unnecessary is_recording() call if span is None
if span is not None and span.is_recording():
span.set_attributes(attributes)


Expand Down