Remove loc search from agent guidance - #171
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Quick fix, removing it from agent guidance as first thing, And in subsequent PR will make the cleanup.
Summary
loc searchfrom generated agent skills, mount-localAGENTS.md, source guidance, and the onboarding promptloc info, andloc locatefor known Notion URLs/titlesTests
cargo test -p loc-cli mount_writes_agent_guidance_and_claude_aliascargo test -p localityd source_guidance_teaches_common_cli_workflowcargo test -p locality-desktop --bin locality-desktop skill_teaches_connector_aware_locality_cli_workflowcargo test -p locality-desktop --bin locality-desktop suggested_prompt_is_source_neutral_and_cli_firstcargo fmt --all -- --checkgit diff --checkNote
cargo test -p locality-desktop agent_guidance; the changed tests passed, but the broader filter failed onagent_guidance::tests::no_supported_agent_fallback_names_locality_source_folderbecause this local machine detects supported agent tooling, so the fallback count is environment-dependent.