Skip to content

Update treasury proposal status when a vote decides the outcome #656

Closed
Closed
Update treasury proposal status when a vote decides the outcome#656
Assignees
bandanadivya
Labels
Stellar WaveIssues in the Stellar wave programbackendminormultisig

Description

@codebestia
codebestia
opened on Oct 20, 2026

Branch: Open your PR against dev. PRs targeting main are closed automatically.

Description:
Proposals stay active forever in the database, whatever the vote count. After each vote, apply the same rule as group_treasury: the proposal passes once approvals reach threshold, and is rejected once rejections exceed memberCount - threshold. Depends on #395.

Acceptance criteria:

  • The status changes inside the same transaction as the vote
  • Votes on a proposal that is no longer active still return the existing 409
  • The new status is broadcast to the conversation room so open clients update without a refresh
  • Tests cover both transitions and the boundary case where approvals equal the threshold exactly

Activity

  1. codebestia
    added
    multisig
    backend
    minor
    on Oct 20, 2026
  2. drips-wave
    added
    Stellar WaveIssues in the Stellar wave program
    on Oct 22, 2026

  3. Stanley-Owoh commented on Oct 22, 2026

    @Stanley-Owoh
    Stanley-Owoh
    on Oct 22, 2026 – with Drips Wave

    @Stanley-Owoh has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Good day maintaner, please i would like to work on this, I have gone through the description and am sure i can handle this task
    I can work on it immediatly with clean code and positive result please assign this issue to me
    Thank you

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Stanley-Owoh to this issue.

  4. bandanadivya commented on Oct 22, 2026

    @bandanadivya
    bandanadivya
    on Oct 22, 2026 – with Drips Wave

    @bandanadivya has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’ve reviewed this issue and understand what needs to be done. I’m confident I can handle it. Please assign it to me. Thank you!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @bandanadivya to this issue.

  5. msbanky commented on Oct 22, 2026

    @msbanky
    msbanky
    on Oct 22, 2026 – with Drips Wave

    @msbanky has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    i can work on this please assign to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @msbanky to this issue.

  6. PRIMO-dgaf commented on Oct 22, 2026

    @PRIMO-dgaf
    PRIMO-dgaf
    on Oct 22, 2026 – with Drips Wave

    @PRIMO-dgaf has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would like to work on this is, I'm fast and reliable, I promise to take care of this with precision and accuracy

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @PRIMO-dgaf to this issue.

  7. Johnsource-hub commented on Oct 22, 2026

    @Johnsource-hub
    Johnsource-hub
    on Oct 22, 2026 – with Drips Wave

    @Johnsource-hub has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Please Maintainer, assign this issue to me. Thank you so much

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Johnsource-hub to this issue.

  8. codebestia
    assigned
    bandanadivya
    on Oct 22, 2026

  9. drips-wave commented on Oct 22, 2026

    @drips-wave
    drips-waveBot
    on Oct 22, 2026 – with Drips Wave

    Congratulations, @bandanadivya! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @bandanadivya: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  10. github-actions commented on Oct 22, 2026

    @github-actions
    github-actionsBot
    on Oct 22, 2026 – with GitHub Actions

    Closed by #686, merged into dev.

  11. github-actions
    closed this as completedon Oct 22, 2026

  12. drips-wave commented on Oct 22, 2026

    @drips-wave
    drips-waveBot
    on Oct 22, 2026 – with Drips Wave

    This issue has been completed by @bandanadivya as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @bandanadivya: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbackendminormultisig

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions