Skip to content

Remove the 'stub' contract ID and synthetic proposal IDs from POST /treasury/propose #654

Closed
Closed
Remove the 'stub' contract ID and synthetic proposal IDs from POST /treasury/propose#654
Assignees
bandanadivya
Labels
Stellar WaveIssues in the Stellar wave programbackendminormultisig

Description

@codebestia
codebestia
opened on Oct 20, 2026

Branch: Open your PR against dev. PRs targeting main are closed automatically.

Description:
POST /treasury/propose stores contractId: process.env.GROUP_TREASURY_CONTRACT_ID ?? 'stub' and proposalId: `prop-${Date.now()}` , so the database rows cannot be matched to on-chain proposals. Require the contract ID from config and accept the on-chain proposal ID from the client, which gets it from propose_withdraw.

Acceptance criteria:

  • GROUP_TREASURY_CONTRACT_ID is added to the config schema; the route never writes 'stub'
  • The request body accepts the on-chain proposalId (validated as a non-negative integer string), and the route stores it
  • A duplicate (contractId, proposalId) returns 409
  • Route test updated

Activity

  1. codebestia
    added
    multisig
    backend
    minor
    on Oct 20, 2026
  2. drips-wave
    added
    Stellar WaveIssues in the Stellar wave program
    on Oct 22, 2026

  3. ayandipe commented on Oct 22, 2026

    @ayandipe
    ayandipe
    on Oct 22, 2026 – with Drips Wave

    @ayandipe has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer,
    kindly assign issue to me for prompt resolution.

    Regards

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @ayandipe to this issue.

  4. Tonychris127 commented on Oct 22, 2026

    @Tonychris127
    Tonychris127
    on Oct 22, 2026 – with Drips Wave

    @Tonychris127 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi! I'd like to work on this issue. I've read the description and I understand what's needed.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tonychris127 to this issue.

  5. Starlitecrypto commented on Oct 22, 2026

    @Starlitecrypto
    Starlitecrypto
    on Oct 22, 2026 – with Drips Wave

    @Starlitecrypto has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    i would like to work on these issues

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Starlitecrypto to this issue.

  6. shotundeibrahimoluwaseyifunmi-ship-it commented on Oct 22, 2026

    @shotundeibrahimoluwaseyifunmi-ship-it
    shotundeibrahimoluwaseyifunmi-ship-it
    on Oct 22, 2026 – with Drips Wave

    @shotundeibrahimoluwaseyifunmi-ship-it has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi, I've gone through the issue description and understand what's expected. I'm ready to get started and handle it.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @shotundeibrahimoluwaseyifunmi-ship-it to this issue.

  7. fablo12 commented on Oct 22, 2026

    @fablo12
    fablo12
    on Oct 22, 2026 – with Drips Wave

    @fablo12 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Kindly assign to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @fablo12 to this issue.

  8. Wumi65 commented on Oct 22, 2026

    @Wumi65
    Wumi65
    on Oct 22, 2026 – with Drips Wave

    @Wumi65 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’ve reviewed the issue and have a clear path to a solid fix. I would love to take this on, feel free to assign it to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Wumi65 to this issue.

  9. bandanadivya commented on Oct 22, 2026

    @bandanadivya
    bandanadivya
    on Oct 22, 2026 – with Drips Wave

    @bandanadivya has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’ve reviewed this issue and understand what needs to be done. I’m confident I can handle it. Please assign it to me. Thank you!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @bandanadivya to this issue.

  10. Stanley-Owoh commented on Oct 22, 2026

    @Stanley-Owoh
    Stanley-Owoh
    on Oct 22, 2026 – with Drips Wave

    @Stanley-Owoh has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Good day maintaner, please i would like to work on this, I have gone through the description and am sure i can handle this task
    I can work on it immediatly with clean code and positive result please assign this issue to me
    Thank you

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Stanley-Owoh to this issue.

  11. Temibell commented on Oct 22, 2026

    @Temibell
    Temibell
    on Oct 22, 2026 – with Drips Wave

    @Temibell has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I can fix this pls assign. ETA 5hrs

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Temibell to this issue.

  12. codebestia
    assigned
    bandanadivya
    on Oct 22, 2026

  13. drips-wave commented on Oct 22, 2026

    @drips-wave
    drips-waveBot
    on Oct 22, 2026 – with Drips Wave

    Congratulations, @bandanadivya! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @bandanadivya: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  14. github-actions commented on Oct 22, 2026

    @github-actions
    github-actionsBot
    on Oct 22, 2026 – with GitHub Actions

    Closed by #686, merged into dev.

  15. github-actions
    closed this as completedon Oct 22, 2026

  16. drips-wave commented on Oct 22, 2026

    @drips-wave
    drips-waveBot
    on Oct 22, 2026 – with Drips Wave

    This issue has been completed by @bandanadivya as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @bandanadivya: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbackendminormultisig

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions