Repository navigation
Stop attributing unmatched transfers to an arbitrary conversation #653
Description
Branch: Open your PR against dev. PRs targeting main are closed automatically.
Description:
When a transfer's memo does not match a message ID, defaultPersistEvent falls back to the first row of conversations and the first row of users, so the transfer shows up in an unrelated chat, attributed to an unrelated user. Unmatched transfers should be stored unattributed or skipped, never assigned at random.
Acceptance criteria:
- The fallback queries are removed
- Either
conversationId/senderIdbecome nullable for unmatched transfers (with a migration), or unmatched events are skipped with a debug log; the PR explains which was chosen - Test: an event whose memo is not a known message ID never creates a row linked to an existing conversation
Activity
Ivenkili commentedon Oct 22, 2026
@Ivenkili has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ivenkili to this issue.
Itodo-S commentedon Oct 22, 2026
@Itodo-S has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Itodo-S to this issue.
stephaniepez21-art commentedon Oct 22, 2026
@stephaniepez21-art has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @stephaniepez21-art to this issue.
anumukul commentedon Oct 22, 2026
@anumukul has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @anumukul to this issue.
tijanib141 commentedon Oct 22, 2026
@tijanib141 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @tijanib141 to this issue.
Peaostrel commentedon Oct 22, 2026
@Peaostrel has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Peaostrel to this issue.
drips-wave commentedon Oct 22, 2026
Congratulations, @anumukul! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @anumukul: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
github-actions commentedon Oct 22, 2026
Closed by #685, merged into
dev.drips-wave commentedon Oct 22, 2026
This issue has been completed by @anumukul as part of the Stellar Wave Program's 10th Wave 🥳
😎 @anumukul: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.