Repository navigation
Contract security review checklist #633
Description
Branch: Open your PR against dev. PRs targeting main are closed automatically.
Description:
Write contracts/docs/security-checklist.md: the checklist a reviewer works through on any contract PR, with each item answered for the three current contracts.
Acceptance criteria:
- Covers at minimum:
require_authon every state-changing entry point, initialization front-running and re-initialization, admin key powers (set_token_contract,upgrade), integer overflow oni128amounts, negative or zero amounts, threshold edge cases (threshold greater than member count, removing members below threshold), double voting, and storage archival - Each item answered per contract with a link to the code or test that proves it, or marked as an open finding
- Notes that tests using
mock_all_authsdo not prove authorization, and links to the testing guide (File integrity verification (hash check on confirm) #348) - Linked from the PR template's contracts section
Activity
arraahmon244-pixel commentedon Oct 20, 2026
@arraahmon244-pixel has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @arraahmon244-pixel to this issue.
Dannyorji commentedon Oct 20, 2026
@Dannyorji has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Dannyorji to this issue.
drips-wave commentedon Oct 20, 2026
Congratulations, @Dannyorji! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @Dannyorji: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
github-actions commentedon Oct 20, 2026
Closed by #646, merged into
dev.drips-wave commentedon Oct 20, 2026
This issue has been completed by @Dannyorji as part of the Stellar Wave Program's 10th Wave 🥳
😎 @Dannyorji: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.