Skip to content

Concepts: push notification decision matrix #622

Closed

Description

@codebestia

Branch: Open your PR against dev. PRs targeting main are closed automatically.

Description:
Write apps/backend/docs/concepts-push-decision-matrix.md: a single answer to "will this user get a push notification for this message?". The rules live in services/pushFilter.ts (shared by the text path dispatchOfflinePush and the file path sendPushForMessage) layered under the coalescing and rate-limiting in services/pushNotification.ts.

Acceptance criteria:

  • A decision table covering every filter: sender excluded, conversation muted, user online on any device, devices.pushEnabled = false, device revoked
  • Clarifies the "online" granularity — whether a user active on one device suppresses push to their other devices
  • Layers in coalescing and per-user rate limits so the table answers the question end to end
  • Documents what the push payload contains and confirms it carries no plaintext message content
  • Notes the test files that pin this behaviour (pushFilter.test.ts, pushNotification.test.ts)

Activity

  1. codus-async commented on Oct 19, 2026

    @codus-async

    @codus-async has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Please assign this to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @codus-async to this issue.

  2. pratyushadk commented on Oct 20, 2026

    @pratyushadk

    @pratyushadk has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Preventing notification spam while guaranteeing critical delivery is key. I'll structure a priority-tiered decision matrix mapping message importance, user presence (active in room vs backgrounded), and rate quotas to appropriate APNs/FCM delivery channels. OSS contributor (Apache Camel & Arrow, github.com/pratyushadk). Ready to knock this out quickly.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @pratyushadk to this issue.

  3. kosisochukwu1234 commented on Oct 20, 2026

    @kosisochukwu1234

    @kosisochukwu1234 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I would love to take on this issue. I'm a software engineer with over 4 years experience. and i'm confident I can resolve this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @kosisochukwu1234 to this issue.

  4. Themancalledpg commented on Oct 20, 2026

    @Themancalledpg
    Contributor

    @Themancalledpg has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hey maintainer please can i work on this issue?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Themancalledpg to this issue.

  5. drips-wave commented on Oct 20, 2026

    @drips-wave

    Congratulations, @Themancalledpg! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Themancalledpg: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  6. github-actions commented on Oct 22, 2026

    @github-actions

    Closed by #680, merged into dev.

  7. drips-wave commented on Oct 22, 2026

    @drips-wave

    This issue has been completed by @Themancalledpg as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Themancalledpg: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programbackenddocumentationImprovements or additions to documentation

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions