Skip to content

Concepts: message edit and delete semantics #618

Closed

Description

@codebestia

Branch: Open your PR against dev. PRs targeting main are closed automatically.

Description:
Write apps/backend/docs/concepts-message-edit-delete.md. Edit and delete behave very differently from a plaintext chat app because the server only holds per-device ciphertext. edit_message stores a new ciphertext with a fresh per-device envelope fan-out that references the original message; delete_message nulls the ciphertext, sets deletedAt, deletes every message_envelopes row for the message, soft-deletes any attached file, and broadcasts message_deleted.

Acceptance criteria:

  • Documents the authorization rule for both (sender only) and the error emitted otherwise
  • Explains what an offline recipient device sees on reconnect or /sync after an edit and after a delete, including whether a deleted message's envelope can still be delivered
  • States the honest limit of delete under E2EE: a recipient device that already decrypted the message keeps the plaintext; the server cannot recall it
  • Documents the sibling-device requirement on edit (missing sibling envelopes are rejected, same as send_message)
  • Documents how edits and deletes interact with the file GC passes (Local-disk object store for development, swappable to S3 in production #330) and with local search indexes on the client

Activity

  1. Jiggie411 commented on Oct 19, 2026

    @Jiggie411

    @Jiggie411 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer have looked into the issue and it's something i could resolve i would like to work on this issue pls assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Jiggie411 to this issue.

  2. pratyushadk commented on Oct 20, 2026

    @pratyushadk

    @pratyushadk has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Happy to help formalize these messaging primitives. I'll outline deterministic state transitions for soft-deletes vs hard-tombstones, edit history immutability, broadcast diff payloads, and client cache invalidation rules. Check out my real-time messaging architecture background at github.com/pratyushadk. Can deliver a comprehensive spec/PR within 1 hour.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @pratyushadk to this issue.

  3. kosisochukwu1234 commented on Oct 20, 2026

    @kosisochukwu1234

    @kosisochukwu1234 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I would love to take on this issue. I'm a software engineer with over 4 years experience. and i'm confident I can resolve this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @kosisochukwu1234 to this issue.

  4. Themancalledpg commented on Oct 20, 2026

    @Themancalledpg
    Contributor

    @Themancalledpg has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hey maintainer please can i work on this issue?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Themancalledpg to this issue.

  5. drips-wave commented on Oct 20, 2026

    @drips-wave

    Congratulations, @Themancalledpg! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Themancalledpg: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  6. github-actions commented on Oct 22, 2026

    @github-actions

    Closed by #680, merged into dev.

  7. drips-wave commented on Oct 22, 2026

    @drips-wave

    This issue has been completed by @Themancalledpg as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Themancalledpg: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programbackenddocumentationImprovements or additions to documentatione2ee

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions