Repository navigation
feat: Infisical as a store (a read-only machine identity) - #148
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The store logs in with Universal Auth and reads one secret through the
request code of the Infisical Go SDK, with its own HTTP client: the
context of the request, no retries, no redirects, no log, no cache, and
a cap of 1 MiB on each answer. The access token stays in memory. A
refused token (401) leads to one more login and one more read. A value
with a reference (${...}) is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lose (#127) From the security review: an answer that still has a Content-Encoding would be decoded by resty after the 1 MiB cap; a read that ends after Close handed out its value. The HTTP client's Timeout did nothing, as the call's context replaces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #127
An
infisicalstore: the broker logs in with a machine identity (Universal Auth) and reads one secret, with the official Infisical Go SDK (the owner's choice).Progress
type = "infisical": config (server, client_id, client_secret_file), secret (project, environment, path, name)${...}value (refused)Choices
CallUniversalAuthLogin,CallRetrieveSecretV3) with its own resty client: no retries, no redirects, no log, no cache, no refresh goroutine, the call's context on each request, and a cap of 1 MiB on each answer.pathis required, with no default: a default/could quietly pick a secret of the same name in another folder.${is refused (open question 3): the tap must show every secret that goes out. Reads ask Infisical not to expand references and not to include imports.Cost of the SDK (new dependencies)
go build -trimpath -ldflags="-s -w"): 26,727,592 bytes before, 32,704,712 after (+22.4 %, with gRPC v1.83.1).github.com/infisical/go-sdkv0.9.1,github.com/go-resty/resty/v2v2.13.1. Indirect: 42 more in go.mod (the AWS SDK, GCP auth and IAM, gRPC, OpenTelemetry, oauth2, zerolog, golang-lru and others) — the SDK'spackages/utilpulls them in even for the two calls nodkey uses.goline moves from 1.26.0 to 1.26.10.Tests:
go test -race ./...andgo vetpass on Go 1.27 with CI=true; the new tests pass with-count=20 -cpu 1,2,4. Go 1.26.0 cannot build the module any more (go.mod needs 1.26.10); CI takes Go from go.mod.Known limit: the value stays in resty's answer buffer until the garbage collector frees it; Go cannot clear it.
🤖 Generated with Claude Code