Skip to content
This repository was archived by the owner on Jul 25, 2019. It is now read-only.
This repository was archived by the owner on Jul 25, 2019. It is now read-only.

generator test uses random source #15

Description

@simbo1905

The following test:

 @Test
  void generate() {
    final SecureRandom random = new SecureRandom(); // <- random 
    final byte[] p = GF256.generate(random, 5, (byte) 20);
   // removed for brevity
   assertThat(p[p.length - 1]).isNotZero();
  }

Will find it hard to catch a bug where generate doesn't loop on the random source until p[p.length - 1] != (byte) 0. If a regression is introduced it is unlikely to be caught before the code is released.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions