Repository navigation
check_ci_conformance: tier-skipped required checks; review fixes - #5
Merged
Merged
Conversation
A matrix job skipped by the fast tier reports one check under its unexpanded name, so a required `name (value)` check from it never arrives and every pull request waits. cocoindex-code-plus requires two such checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- check_ci_conformance: a job whose `if` uses cancelled() or failure() runs when the job it needs is skipped, so it does not inherit the draft skip; only always() was recognized. - apply_rulesets: `gh api --paginate` prints one JSON array per page; `--slurp` wraps them so more than one page parses. - The kit's first commit tracked scripts/__pycache__; untrack it and ignore __pycache__/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
georgeh0
changed the title
… matching - ci-conformance: a ruleset runs a required workflow only on opened, synchronize and reopened and ignores `types`, so a draft marked ready got no new run of the skipped job. Run it on drafts too. - The starter workflow skips the path filter for a stack layer: on a pull request the filter lists the layer's own files, but the top layer's run stands in for the whole stack. CI.md says to diff stack layers against the stack base. - check_ci_conformance: a required check matches a job only by its name, a matrix leg `name (...)` or a reusable call `name / ...` (a `test` job no longer satisfies `test-e2e`); tier skips propagate through `needs`; a skipped reusable-workflow call is flagged like a skipped matrix job; the short form `concurrency: <group>` no longer crashes the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name (value)check from it never arrives and pull requests wait forever. The checker now flags such required checks and says to requireci-gate; CI.md says which checks to require.ifusescancelled()orfailure()runs when the job it needs is skipped, so it no longer passes the draft rule;apply_rulesets.pyreads every page of rulesets (--paginate --slurp); thescripts/__pycache__files that Add the CI kit: CI shape, ci-mode action, conformance, rulesets #4 committed are untracked and ignored.Test plan
self-test.yml.pre-commit (3.11)andpre-commit (3.13), which its ruleset requires today. The cocoindex, cocoindex-plus and cocoindex-code branches still conform.gh api --paginate --slurpchecked against a real rulesets endpoint with one item per page.🤖 Generated with Claude Code