cmd: add visus node list subcommand with heartbeat#254
Merged
Conversation
|
LGTM, with two comments |
BramGruneir
approved these changes
Mar 17, 2026
| "github.com/cockroachlabs/visus/internal/store" | ||
| "github.com/go-co-op/gocron" | ||
| "github.com/google/uuid" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
please use "github.com/cockroachdb/errors" instead of pkg/errors
Contributor
Author
There was a problem hiding this comment.
I'm using pkg/errors in this repo... filed #256
|
|
||
| // TestCommands verifies the behavior of each CLI command. | ||
| func TestCommands(t *testing.T) { | ||
| ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) |
There was a problem hiding this comment.
Just note that this if 5 seconds for all the tests, not a test-by-test basis
On startup, the server registers itself in the node table and schedules a 1-minute heartbeat job. On graceful shutdown the node deregisters itself. The `visus node list` command displays ID, HOSTNAME, PID, VERSION, UPDATED columns for all registered nodes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On startup, the server registers itself in the node table and schedules a 1-minute heartbeat job. On graceful shutdown the node deregisters itself.
The
visus node listcommand displays ID, HOSTNAME, PID, VERSION, UPDATED columns for all registered nodes.