store: add version field to NodeInfo#252
Merged
Merged
Conversation
BramGruneir
approved these changes
Mar 16, 2026
BramGruneir
left a comment
BramGruneir
left a comment
There was a problem hiding this comment.
LGTM, but you might want to update how you scan rows, see my comment for details.
| for rows.Next() { | ||
| var n NodeInfo | ||
| if err := rows.Scan(&n.ID, &n.Hostname, &n.PID, &n.Updated); err != nil { | ||
| if err := rows.Scan(&n.ID, &n.Hostname, &n.PID, &n.Version, &n.Updated); err != nil { |
There was a problem hiding this comment.
PGX now has a much nicer version of this, where you can just have it match by name and insert into the struct. It's not more efficient, but it read so much nicer and it should catch any errors when the order changes.
Look for pgx.RowToStructByName
Contributor
Author
There was a problem hiding this comment.
I keep forget about this.. Done.
Allow nodes to report which version of visus they are running, useful for monitoring rolling upgrades. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow nodes to report which version of visus they are running, useful for monitoring rolling upgrades.