fix(web): target icon for Goal, working new-task shortcut, ⌘J terminal alias - #146
Conversation
…l alias
Goal icon
- Replace BoltIcon with ViewfinderCircleIcon (crosshair / target) in the
GoalBanner and the ChatInput Goal menu item + armed chip. The bolt icon
is kept for non-Goal settings rows (small model, BLE, MCP).
New-task shortcut was broken
- ⌘N dispatched loadSession(''), whose thunk short-circuited on the empty
uuid (the "handled in Sidebar" comment was aspirational — nothing there
handled it), so the shortcut did nothing. Extract a shared startNewChat
thunk (clear timeline → switch to chat view → allocate a fresh session id)
and wire both ⌘N (desktop, where Tauri has no native menu to eat it) and
⇧⌘O (browser, where ⌘N is reserved by the OS) to it. Sidebar's "new task"
button calls the same thunk; the displayed hint becomes ⇧⌘O.
Terminal shortcut was unreachable on macOS
- ⌘` is eaten by macOS window cycling and never reaches the page. Add ⌘J as
an alias (with !shiftKey so ⇧⌘J DevTools stays intact) and surface it in
the settings shortcuts list. ⌘` stays as an additional trigger where it
does fire.
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Goal 图标 → 靶心
BoltIcon（闪电）→ViewfinderCircleIcon（准星 / 靶心），覆盖GoalBanner活跃目标横幅与ChatInput的 Goal 菜单项 + armed 状态 chip。设置页里的闪电用于小模型 / BLE / MCP，与 Goal 无关，未动。新建任务快捷键根本没生效
双重 bug：
⌘N调用loadSession('')，空 uuid 使 thunk 在api.session('')处提前 return，注释里写的 "handled in Sidebar" 实际从未实现。⌘N在浏览器里被系统保留（新开窗口），页面无法拦截。修复：抽出共享 thunk
startNewChat（清空 timeline → 切到 chat 视图 → 分配新 session id），Sidebar 的「新建任务」按钮也改用它：⇧⌘O新建任务⌘N新建任务⌘J终端面板⌘\`` 在 macOS 被系统窗口切换吃掉；⌘J 为 VS Code 风格别名，带!shiftKey` 守卫不影响 ⇧⌘J DevTools测试
tsc --noEmit通过make build-web通过