fix: plugin-barman-cloud port for readiness probe#776
Conversation
Signed-off-by: Jan Larwig <jan@larwig.com>
tuunit
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
Bot
added
size:XS
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the readiness probe configuration for high-availability setups. The readiness probe was checking port 9090 (the application port), which is only available on the leader pod. In HA deployments with multiple replicas, non-leader pods would fail readiness checks since they only expose the health/metrics port 8081.
Key Changes:
- Updated readiness probe to use port 8081 instead of 9090 for proper HA support
- Bumped chart version from 0.4.0 to 0.4.1 (patch version for bug fix)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/plugin-barman-cloud/templates/deployment.yaml | Fixed readiness probe to check port 8081 (health/metrics) instead of 9090 (application port) |
| charts/plugin-barman-cloud/Chart.yaml | Incremented patch version to 0.4.1 to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gbartolini
added
the
chart( plugin-barman-cloud )
| tcpSocket: | ||
| port: 9090 | ||
| port: 8081 |
There was a problem hiding this comment.
You can also use:
httpGet:
path: /readyz
port: 8081
scheme: httpand /healthz for liveness probe
There was a problem hiding this comment.
Nevertheless, both options require a chart change. Maybe the probe should be made configurable.
@gbartolini what's your opinion on the matter?
|
@itay-grudev @mnencia could you have a look at this change? highly appreciated |
Signed-off-by: Jan Larwig <jan@larwig.com>
|
Hi, also looking for this fix 🙏 |
|
Friendly ping @itay-grudev @mnencia |
Signed-off-by: Itay Grudev <itay+github.com@grudev.com>
|
If I am not mistaken, the liveness probe proposal in #707 would suffer from the same issue. Could you add it in this PR with the corrected port? |
Description
At the moment the port
9090is used for the readiness probe which is the application port which only get opened / used by the leader. For an HA setup with multiple pods this fails because none leaders only open the health/metrics port8081.Fixes #710