Add cljfmt formatting config and lint/tidy scripts - #952
Draft
danielcompton wants to merge 1 commit into
Draft
Conversation
Set up a cljfmt.edn tuned to the existing code style (preserves double blank lines, keeps the compojure route and clojure.test indentation the repo already uses) so formatting checks don't churn unrelated code. Adds a :cljfmt deps alias, scripts/lint and scripts/tidy wrappers, a make tidy target, and a CircleCI step to check formatting. Reformats the one outlier block in admin.clj to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tobias
reviewed
Jun 3, 2026
tobias
left a comment
tobias
left a comment
Member
There was a problem hiding this comment.
We already have a cljstyle config (.cljstyle) and script (bin/cljstyle); what would be the advantage of moving to cljfmt?
One thing I like about cljstyle is it is graal-compiled, so is fast enough to run on save from my editor. It is also a fork of cljfmt, so should support the same features (unless cljfmt has moved ahead).
If we do switch, the wrapper scripts should be in bin instead of scripts; scripts is for scripts that get bundled with a release and used on the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up a
cljfmt.edntuned to the repo's existing code style — it preserves the occasional double blank lines, keeps the compojure route indentation (GET/POST/etc.), and matches theclojure.testand kerodon assertion alignment, so running cljfmt doesn't churn unrelated code. Adds a:cljfmtdeps alias along withscripts/lint(check) andscripts/tidy(fix) wrappers, amake tidytarget, and a CircleCI "Check formatting" step. Reformats the single outlier block inadmin.cljso the codebase passes the check cleanly.🤖 Generated with Claude Code