ci(smoke-test): pass workflow inputs through env vars#173
Conversation
|
|
Stack: security-codeql-fixes
Part of a stacked PR chain. Do not merge manually. |
194fa04 to
cc1585b
Compare
68c54c5 to
94620e0
Compare
cc1585b to
e2a4f3f
Compare
94620e0 to
7bfbe2a
Compare
e2a4f3f to
1c2041e
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe GitHub Actions workflow Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Move `inputs.preset`, `inputs.version`, `matrix.docker`, and `matrix.bin` into `env:` blocks so shell interpolation happens after variable expansion rather than template substitution. Closes the CodeQL actions/code-injection/critical finding on the version comparison. The values are already gated upstream (release.yml requires author_association in MEMBER/OWNER for issue_comment triggers), so this is defense-in-depth, but the pattern is cheap to follow and eliminates the rule entirely.
1c2041e to
ac671af
Compare
Summary
inputs.preset,inputs.version,matrix.docker, andmatrix.binfrom inline${{ ... }}template substitution inrun:blocks toenv:bindings, so shell interpolation happens after expansion rather than before.release.ymlalready restrictsissue_commenttriggers toMEMBER/OWNERactors, but the pattern is cheap to follow and eliminates the rule entirely.actions/code-injection/criticalalert on the smoke-test version check.Test plan